Skip to content

Comments

feat(ecs): throw ValidationErrors instead of untyped errors#34427

Merged
mergify[bot] merged 2 commits intomainfrom
mrgrain/feat/ecs
May 13, 2025
Merged

feat(ecs): throw ValidationErrors instead of untyped errors#34427
mergify[bot] merged 2 commits intomainfrom
mrgrain/feat/ecs

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 12, 2025 •
edited
Loading

Issue

Relates to #32569

Reason for this change

untyped Errors are not recommended

Description of changes

ValidationErrors everywhere

Describe any new or updated permissions being added

None

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2025 16:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 12, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (bc7c4e8) to head (2cc3b46).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #34427   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         124      124           
  Lines        7009     7009           
  Branches     1176     1176           
=======================================
  Hits         5895     5895           
  Misses       1003     1003           
  Partials      111      111
Flag Coverage Δ
suite.unit 84.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 84.10% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain changed the title feat(ecs): throw typed errors feat(ecs): throw ValidationErrors instead of untyped Errors May 12, 2025
@mrgrain mrgrain changed the title feat(ecs): throw ValidationErrors instead of untyped Errors feat(ecs): throw ValidationErrors instead of untyped Errors May 12, 2025
@mrgrain mrgrain changed the title feat(ecs): throw ValidationErrors instead of untyped Errors feat(ecs): throw ValidationErrors instead of untyped errors May 12, 2025
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 12, 2025 20:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2025
@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34427 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mrgrain
Copy link
Contributor Author

mrgrain commented May 12, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 12, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mrgrain mrgrain force-pushed the mrgrain/feat/ecs branch from dc55f1c to 2f51d5a Compare May 13, 2025 07:25
@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34427 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented May 13, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2cc3b46
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5cfea39 into main May 13, 2025
21 checks passed
@mergify mergify bot deleted the mrgrain/feat/ecs branch May 13, 2025 13:59
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrgrain @aws-cdk-automation @kaizencc